Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay null file handle closure until after post-processing #227

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

godotalgorithm
Copy link
Collaborator

Fixes #226.

Status

  • Ready for merge

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.98%. Comparing base (c92b082) to head (cd9b9aa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   67.98%   67.98%           
=======================================
  Files         339      339           
  Lines       77435    77435           
=======================================
+ Hits        52646    52648    +2     
+ Misses      24789    24787    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godotalgorithm godotalgorithm merged commit c44737d into main Nov 17, 2024
9 checks passed
@godotalgorithm godotalgorithm deleted the stray-disk-access branch November 17, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diskless API writes fort.26 file containing dipole information
1 participant