Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API bug fix #222

Merged
merged 4 commits into from
Nov 11, 2024
Merged

API bug fix #222

merged 4 commits into from
Nov 11, 2024

Conversation

godotalgorithm
Copy link
Collaborator

This fixes #220 and adds some clarifications about MOPAC thread safety to the main README file. I was able to reproduce the reported bugs in a different example that I had lying around, and these changes fixed the bugs in that example.

Status

  • Ready for merge

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.97%. Comparing base (0871ae8) to head (a9d865c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/input/getgeo.F90 50.00% 2 Missing ⚠️
src/input/gettxt.F90 33.33% 2 Missing ⚠️
src/input/readmo.F90 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files         339      339           
  Lines       77421    77424    +3     
=======================================
+ Hits        52628    52631    +3     
  Misses      24793    24793           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godotalgorithm godotalgorithm merged commit 8968283 into main Nov 11, 2024
9 checks passed
@godotalgorithm godotalgorithm deleted the api-bugfix branch November 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mixing disk-based and diskless API causes issues
1 participant