Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for header packaging #221

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Patch for header packaging #221

merged 3 commits into from
Nov 11, 2024

Conversation

godotalgorithm
Copy link
Collaborator

@godotalgorithm godotalgorithm commented Nov 10, 2024

The C header file was not being packaged correctly by cmake install. This fixes the packaging and also changes the name of the header file to be more consistent with the library name. I also added the option to turn off git hash info to clean up the conda-forge packaging.

Status

  • [] Ready for merge

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (77cdb6a) to head (2c10543).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files         339      339           
  Lines       77421    77421           
=======================================
  Hits        52628    52628           
  Misses      24793    24793           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godotalgorithm godotalgorithm merged commit 0871ae8 into main Nov 11, 2024
9 checks passed
@godotalgorithm godotalgorithm deleted the patch23 branch November 11, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant