Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C binding of API #218

Merged
merged 30 commits into from
Nov 9, 2024
Merged

C binding of API #218

merged 30 commits into from
Nov 9, 2024

Conversation

godotalgorithm
Copy link
Collaborator

To make MOPAC more portable as a shared library, I have switched its new API to a C binding. This may be inconvenient to use in other Fortran-based software, so I also added a wrapper that re-implements the previous native Fortran API on top of the C binding.

Status

  • Ready for merge

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 76.64122% with 153 lines in your changes missing coverage. Please review.

Project coverage is 67.97%. Comparing base (b03d904) to head (cd0d325).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
src/interface/mopac_api_createdestroy.F90 63.87% 56 Missing ⚠️
include/mopac_api_internal.F90 83.14% 45 Missing ⚠️
src/interface/mopac_api_finalize.F90 72.41% 16 Missing ⚠️
src/interface/mopac_api_operations.F90 33.33% 12 Missing ⚠️
src/MOZYME/iter_for_MOZYME.F90 0.00% 8 Missing ⚠️
src/interface/mopac_api_saveload.F90 86.44% 8 Missing ⚠️
src/interface/mopac_api_initialize.F90 84.21% 3 Missing ⚠️
src/run_mopac.F90 33.33% 2 Missing ⚠️
tests/mopac_api_test.F90 97.01% 2 Missing ⚠️
include/mopac_api_f.F90 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   67.93%   67.97%   +0.04%     
==========================================
  Files         336      339       +3     
  Lines       77025    77421     +396     
==========================================
+ Hits        52326    52628     +302     
- Misses      24699    24793      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@godotalgorithm godotalgorithm merged commit d5a01db into main Nov 9, 2024
9 checks passed
@godotalgorithm godotalgorithm deleted the bindc-api branch November 9, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant