Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #171] Dledger Support properties configuration file #182

Closed
wants to merge 1 commit into from
Closed

[ISSUE #171] Dledger Support properties configuration file #182

wants to merge 1 commit into from

Conversation

mxsm
Copy link
Contributor

@mxsm mxsm commented Jul 16, 2022 •
edited
Loading

ISSUE #171

  • Dledger Support properties configuration file

tsunghanjacktsai
tsunghanjacktsai reviewed Jul 18, 2022
View reviewed changes
Copy link
Contributor

@tsunghanjacktsai tsunghanjacktsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mxsm ,

Really thanks for your contribution to DLedger. But I guess this PR is a bit similar to what @TheR1sing3un trying to achieve in #150 . Maybe you should take a look and make sure your ideas didn't conflict.

@mxsm
Copy link
Contributor Author

mxsm commented Jul 22, 2022

Thanks for you remind @tsunghanjacktsai , I will develop the new feature on #150 PR

@mxsm mxsm closed this Jul 22, 2022
@mxsm mxsm deleted the dledger-171 branch September 9, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsunghanjacktsai tsunghanjacktsai tsunghanjacktsai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxsm @tsunghanjacktsai