Development Environment Docs & Improvements #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…repo in dev environment. add seed data
arfon
reviewed
Oct 6, 2024
| @@ -146,7 +146,7 @@ class Paper < ApplicationRecord | |||
| validates :kind, inclusion: { in: Rails.application.settings["paper_types"] }, allow_nil: true | |||
| validates :submission_kind, inclusion: { in: SUBMISSION_KINDS, message: "You must select a submission type" }, allow_nil: false | |||
| validates_format_of :repository_url, with: /\Ahttps?:\/\//i, on: :create, message: "Repository URL is missing the protocol segment (http/https)" | |||
| validate :check_repository_address, on: :create, unless: Proc.new {|paper| paper.is_a_retraction_notice?} | |||
| validate :check_repository_address, on: :create, unless: Proc.new {|paper| Rails.env.development? || paper.is_a_retraction_notice?} | |||
arfon
approved these changes
Oct 6, 2024
|
Thanks @sneakers-the-rat ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo: #1356 without model annotations
This PR:
Paperobjects if in the development environment so that it's possible to create fake papers/reviews for testingQuestions:
specdirectory like https://github.com/openjournals/joss/blob/main/spec/factories/papers_factory.rb indb/seeds.rb? I don't know enough about ruby environments, wasn't sure how to call that, but that would probably be preferable to use those, so then we could create a full seed dataset with all the types of models from the same sources that the tests use. If that is possible/desirable, i can follow on with another PR for that, seems like it would be a nice thing to do both for people checking this out if they wanted to do a secondary deployment and also for quick debugging purposes.