Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails #1185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 27, 2024

Hi all,

This pull request contains a backport of commit 3a625f38 from the openjdk/jdk repository.

The commit being backported was authored by Doug Simon on 26 Nov 2024 and was reviewed by SendaoYan, Dean Long and Hamlin Li.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8344628 needs maintainer approval

Issue

  • JDK-8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1185/head:pull/1185
$ git checkout pull/1185

Update a local copy of the PR:
$ git checkout pull/1185
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1185/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1185

View PR using the GUI difftool:
$ git pr show -t 1185

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1185.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 3a625f38aa4ab611fe5c7dffe420abce826d0d7e 8344628: Test TestEnableJVMCIProduct.java run with virtual thread intermittent fails Nov 27, 2024
@openjdk
Copy link

openjdk bot commented Nov 27, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant