Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set #1176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

swesonga
Copy link
Contributor

@swesonga swesonga commented Nov 22, 2024

Backport openjdk/jdk23u@7f189a5 to jdk23u. UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passes in fastdebug on Windows AArch64 with this change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8334475 needs maintainer approval

Issue

  • JDK-8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1176/head:pull/1176
$ git checkout pull/1176

Update a local copy of the PR:
$ git checkout pull/1176
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1176

View PR using the GUI difftool:
$ git pr show -t 1176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1176.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back swesonga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@swesonga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 50aa07e: 8343877: Test AsyncClose.java intermittent fails - Socket.getInputStream().read() wasn't preempted
  • 149991d: 8338344: Test TestPrivilegedMode.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Platform
  • 7045581: 8316893: Compile without -fno-delete-null-pointer-checks
  • bc4abb4: 8340552: Harden TzdbZoneRulesCompiler against missing zone names
  • ef5702e: 8316907: Fix nonnull-compare warnings
  • 50fc231: 8343884: [s390x] Disallow OptoScheduling
  • f091c76: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64
  • 4bbc29c: 8319678: Several tests from corelibs areas ignore VM flags
  • add7934: 8339637: (tz) Update Timezone Data to 2024b
  • 322fc81: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
  • ... and 7 more: https://git.openjdk.org/jdk21u-dev/compare/4b1365eaab151ecf5ff2c40e4292d93137499c06...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 7f189a59d9ad803aee72565bc46a817d3f46f2e5 8334475: UnsafeIntrinsicsTest.java#ZGenerationalDebug assert(!assert_on_failure) failed: Has low-order bits set Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

⚠️ @swesonga This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

@swesonga
Copy link
Contributor Author

/approval request for jdk21u backport with all tier1 tests passing and the UnsafeIntrinsicsTest.java#ZGenerationalDebug test now passing in the Windows AArch64 fastdebug build.

@openjdk
Copy link

openjdk bot commented Nov 25, 2024

@swesonga
8334475: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Nov 25, 2024
@swesonga
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 25, 2024
@openjdk
Copy link

openjdk bot commented Nov 25, 2024

@swesonga
Your change (at version cdbf48f) is now ready to be sponsored by a Committer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
Development

Successfully merging this pull request may close these issues.

1 participant