Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 #1170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chadrako
Copy link
Contributor

@chadrako chadrako commented Nov 20, 2024

Backport JDK-8341194 [REDO] Implement C2 VectorizedHashCode on AArch64

Backport is clean. Trivial merge conflicts with includes and already present code. Original implementation JDK-8322770 caused build and test failures. Build failures that were reproducible with make bootcycle-images run on linux-aarch64 fastdebug/release successfully. All jtreg and new asmtest pass on linux-aarch64 release.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8341194 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 (Enhancement - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1170/head:pull/1170
$ git checkout pull/1170

Update a local copy of the PR:
$ git checkout pull/1170
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1170/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1170

View PR using the GUI difftool:
$ git pr show -t 1170

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1170.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2024

👋 Welcome back chadrako! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4fc6d4135e795d18a024a6035908f380b81082d1 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 20, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

⚠️ @chadrako This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@chadrako
Copy link
Contributor Author

/approval request Clean backport to add C2 VectorizedHashCode on AArch64 for performance improvements. The change has been verified with all jtreg tests tiers on linux-aarch64 release and linux-aarch64 fastdebug

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@chadrako
8341194: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 22, 2024
@GoeLin
Copy link
Member

GoeLin commented Nov 28, 2024

Hi,
I would like to defer this to the April release.
It is an enhancement and rather new. That way it will have at lease some coverage by 24,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants