8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows

[tkiriyama]

Hi all,

I want to backport JDK-8333427 for jdk21u.
This is clean backport. It changes only one test.

Testing: langtools/tools/javac/newlines/NewLineTest.java

---

Progress

• Change must not contain extraneous whitespace
• JDK-8333427 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1132/head:pull/1132
$ git checkout pull/1132

Update a local copy of the PR:
$ git checkout pull/1132
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1132

View PR using the GUI difftool:
$ git pr show -t 1132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1132.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkiriyama This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333427: langtools/tools/javac/newlines/NewLineTest.java is failing on Japanese Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

• 50fc231: 8343884: [s390x] Disallow OptoScheduling
• f091c76: 8333248: VectorGatherMaskFoldingTest.java failed when maximum vector bits is 64
• 4bbc29c: 8319678: Several tests from corelibs areas ignore VM flags
• add7934: 8339637: (tz) Update Timezone Data to 2024b
• 322fc81: 8328619: sun/management/jmxremote/bootstrap/SSLConfigFilePermissionTest.java failed with BindException: Address already in use
• 3aa59b3: 8341722: Fix some warnings as errors when building on Linux with toolchain clang
• 2029e4e: 8337826: Improve logging in OCSPTimeout and SimpleOCSPResponder to help diagnose JDK-8309754
• f9cd285: 8338550: Do libubsan1 installation in test container only if requested
• 936b239: 8325525: Create jtreg test case for JDK-8325203
• cb9a6a2: 8333144: docker tests do not work when ubsan is configured
• ... and 33 more: https://git.openjdk.org/jdk21u-dev/compare/bb60a427d7b9bc8b33091daa7d7e4a37256f93bc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @tkiriyama This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (1c7989ff)

[tkiriyama]

GHA failures are unrelated.

[tkiriyama]

/approval request This is clean backport. It fixes only one test and the risk is low. The test fixed in this commit is passed.

[openjdk]

@tkiriyama
8333427: The approval request has been created successfully.

[tkiriyama]

/integrate

[openjdk]

@tkiriyama
Your change (at version 1c7989f) is now ready to be sponsored by a Committer.