8301118: Ignore allow and disallow options for java.security.manager System Property

[dimitryc]

Proposing the change for parity with Oracle (fixed in 11.0.21-oracle).

The change isn't a backport and it's implemented according to the description of https://bugs.openjdk.org/browse/JDK-8301118. New allow/disallow options for the java.security.manager system property should be ignored in JDK11.

New test fails without the change and passes with the change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8301118 needs maintainer approval
• Commit message must refer to an issue
• Change requires CSR request JDK-8301251 to be approved

Issues

• JDK-8301118: Ignore allow and disallow options for java.security.manager System Property (Enhancement - P3 - Requested) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.
• JDK-8301251: Ignore allow and disallow options for java.security.manager System Property (CSR)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2932/head:pull/2932
$ git checkout pull/2932

Update a local copy of the PR:
$ git checkout pull/2932
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2932/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2932

View PR using the GUI difftool:
$ git pr show -t 2932

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2932.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[mlbridge]

Webrevs

• 00: Full (3e0233bc)

[bridgekeeper]

@dimitryc This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[dimitryc]

Kindly reminder

[phohensee]

Change lgtm, would be good to check Oracle 11u to see whether it issues a warning.

The OSX build failures appear unrelated but should be addressed in a different PR.

[openjdk]

⚠️ @dimitryc This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[dimitryc]

@phohensee Thanks for the review!

[dimitryc]

/approval request Proposing the change for parity with Oracle (fixed in 11.0.21-oracle). The change isn't a backport change and implemented according to the description of the issue. New allow/disallow options for the java.security.manager system property should be ignored in JDK11.

[openjdk]

@dimitryc
8301118: The approval request has been created successfully.