Fixed a bug where continueOnError would be missing required metadata …

…property
openintegrationhub · Jul 3, 2024 · d604dbe · d604dbe
1 parent 2d36220
commit d604dbe
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/templates/lib/actions/action.js b/templates/lib/actions/action.js
@@ -48,7 +48,7 @@ async function processAction(msg, cfg, snapshot, incomingMessageHeaders, tokenDa
     );
 
     const specPath = spec.paths[pathName];
-    const specPathGeneralParams = specPath.parameters? specPath.parameters.map(({ name }) => name) : [];
+    const specPathGeneralParams = specPath.parameters ? specPath.parameters.map(({ name }) => name) : [];
     const specPathParameters = specPath[method].parameters ? specPath[method].parameters.map(({ name }) => name) : [];
     specPathParameters.push(...specPathGeneralParams);
 
@@ -61,7 +61,7 @@ async function processAction(msg, cfg, snapshot, incomingMessageHeaders, tokenDa
 
     let parameters = {};
     for (let param of specPathParameters) {
-      if (body[param]){
+      if (body[param]) {
         parameters[param] = body[param];
       }
     }
@@ -102,7 +102,7 @@ async function processAction(msg, cfg, snapshot, incomingMessageHeaders, tokenDa
     this.logger.info("Execution finished");
   } catch (e) {
     if (continueOnError === true) {
-      this.emit('data', { data: {} });
+      this.emit('data', { data: {}, metadata: {} });
     } else {
       this.emit('error', e);
     }

diff --git a/templates/lib/triggers/trigger.js b/templates/lib/triggers/trigger.js
@@ -61,7 +61,7 @@ async function processTrigger(msg, cfg, snapshot, incomingMessageHeaders, tokenD
     );
 
     const specPath = spec.paths[pathName];
-    const specPathGeneralParams = specPath.parameters? specPath.parameters.map(({ name }) => name) : [];
+    const specPathGeneralParams = specPath.parameters ? specPath.parameters.map(({ name }) => name) : [];
     const specPathParameters = specPath[method].parameters ? specPath[method].parameters.map(({ name }) => name) : [];
     specPathParameters.push(...specPathGeneralParams);
 
@@ -159,7 +159,7 @@ async function processTrigger(msg, cfg, snapshot, incomingMessageHeaders, tokenD
     logger.info("Execution finished");
   } catch (e) {
     if (continueOnError === true) {
-      this.emit('data', { data: {} });
+      this.emit('data', { data: {}, metadata: {} });
     } else {
       this.emit('error', e);
     }

diff --git a/templates/lib/utils/helpers.test.js b/templates/lib/utils/helpers.test.js
@@ -1,6 +1,7 @@
 const {
   isMicrosoftJsonDate,
   getInitialSnapshotValue,
+  compareDate,
 } = require("./helpers");
 const dayjs = require('dayjs');
 
@@ -15,8 +16,14 @@ describe("Helpers", () => {
       const date = isMicrosoftJsonDate("2020-01-01T00:00:00.000Z");
       expect(date).toEqual(null);
     });
+
+    it("should handle integer comparisons", () => {
+      const result = compareDate(4, 0);
+      expect(result).toEqual(true);
+    });
   });
 
+
   describe("getInitialSnapshotValue", () => {
     it("should return null date when nothing is set", () => {
       const initialSnapshot = getInitialSnapshotValue({}, {});