-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email log in and register #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Nov 20, 2023
Apply Sweep Rules to your PR?
|
I have read the CLA Document and I hereby sign the CLA |
openimbot
added a commit
to openim-sigs/cla
that referenced
this pull request
Nov 28, 2023
FGadvancer
previously approved these changes
Nov 28, 2023
cubxxw
previously approved these changes
Nov 29, 2023
I would like to suggest the addition of testing functions and test cases. |
I have read the CLA Document and I hereby sign the CLA |
cubxxw
approved these changes
Nov 29, 2023
skiffer-git
approved these changes
Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
/kind feature
👀 What this PR does / why we need it:
Add a new feature.
🅰 Which issue(s) this PR fixes:
No related issue.
📝 Special notes for your reviewer:
This feature enhances the application by adding email register and login. It has been thoroughly tested and aligns with the project's guidelines.
🎯 Describe how to verify it
Please run
make all
to verify the feature. All tests have passed locally.📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: