Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email log in and register #271

Merged
merged 10 commits into from
Dec 1, 2023
Merged

Email log in and register #271

merged 10 commits into from
Dec 1, 2023

Conversation

AndrewZuo01
Copy link
Contributor

🔍 What type of PR is this?

/kind feature

👀 What this PR does / why we need it:

Add a new feature.

🅰 Which issue(s) this PR fixes:

No related issue.

📝 Special notes for your reviewer:

This feature enhances the application by adding email register and login. It has been thoroughly tested and aligns with the project's guidelines.

🎯 Describe how to verify it

Please run make all to verify the feature. All tests have passed locally.

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

  • RFC Document: [Link to RFC document]
  • Usage Documentation: [Link to usage documentation]

@AndrewZuo01 AndrewZuo01 requested review from cubxxw and a team as code owners November 20, 2023 09:04
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 20, 2023
@kubbot
Copy link
Contributor

kubbot commented Nov 20, 2023

CLA Assistant Lite bot 🤖 All Contributors have signed the chat CLA.
The signed information is recorded 🤖here

Copy link

sweep-ai bot commented Nov 20, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@AndrewZuo01
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

openimbot added a commit to openim-sigs/cla that referenced this pull request Nov 28, 2023
FGadvancer
FGadvancer previously approved these changes Nov 28, 2023
cubxxw
cubxxw previously approved these changes Nov 29, 2023
@cubxxw
Copy link
Contributor

cubxxw commented Nov 29, 2023

I would like to suggest the addition of testing functions and test cases.

@AndrewZuo01
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@cubxxw cubxxw added this pull request to the merge queue Dec 1, 2023
Merged via the queue into openimsdk:main with commit 95561a0 Dec 1, 2023
11 checks passed
@openimsdk openimsdk locked and limited conversation to collaborators Dec 1, 2023
@AndrewZuo01 AndrewZuo01 deleted the email-log-in branch December 1, 2023 02:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants