Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tools pkg #244

Closed
wants to merge 34 commits into from
Closed

chore: update tools pkg #244

wants to merge 34 commits into from

Conversation

withchao
Copy link
Collaborator


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #243

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@withchao withchao requested review from cubxxw and a team as code owners October 26, 2023 04:20
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2023
@withchao withchao temporarily deployed to openim October 26, 2023 04:20 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 26, 2023 04:20 — with GitHub Actions Inactive
@withchao withchao temporarily deployed to openim October 26, 2023 04:20 — with GitHub Actions Inactive
@sweep-ai
Copy link

sweep-ai bot commented Oct 26, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@withchao withchao closed this Oct 26, 2023
@openimsdk openimsdk locked and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Other]: update tools pkg
1 participant