Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OM-47: assign msmystem roles to imis user #7

Merged
merged 11 commits into from
Oct 31, 2023
Merged

OM-47: assign msmystem roles to imis user #7

merged 11 commits into from
Oct 31, 2023

Conversation

jdolkowski
Copy link

https://openimis.atlassian.net/browse/OM-47

This PR assigns imis role that is equivalent to msystem role to the user on creation and each update.

@jdolkowski jdolkowski marked this pull request as draft October 27, 2023 14:24
@jdolkowski jdolkowski marked this pull request as ready for review October 30, 2023 15:23
malinowskikam
malinowskikam requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@malinowskikam malinowskikam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I left some comments

msystems/migrations/0002_add_roles.py Outdated Show resolved Hide resolved
msystems/services.py Outdated Show resolved Hide resolved
msystems/services.py Outdated Show resolved Hide resolved
msystems/tests/saml_user_service_tests.py Outdated Show resolved Hide resolved
malinowskikam
malinowskikam approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@malinowskikam malinowskikam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.5% 77.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@malinowskikam malinowskikam merged commit 518ed4e into develop Oct 31, 2023
6 of 13 checks passed
@malinowskikam malinowskikam deleted the feature/OM-47 branch October 31, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malinowskikam malinowskikam malinowskikam approved these changes

@dborowiecki dborowiecki Awaiting requested review from dborowiecki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdolkowski @malinowskikam