Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CQI-80: OWASP A01:2021-Broken Access Control - openimis-be-core_py BE #226

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

sniedzielski
Copy link
Contributor

@sniedzielski sniedzielski commented Oct 18, 2023

TICKET: https://openimis.atlassian.net/browse/CQI-80

Solving issues with CSRF : 275f3f9, 1d907f7

Addressing Password-Related Issues: One of the issues at the service level is not related to setting the password but hardcoded encoded in base64 'stored_password'

i_user.stored_password = "locked"
. In the legacy version, setting the password for a User was optional, and this approach is retained here to maintain compatibility. For sure this part of code and mechanism can be improved, but at this stage we can mark this code as SAFE in my opinion.

Issues to fix: 2/10
False positive issues: 8/10

@sniedzielski sniedzielski changed the title NOT TO MERGE - CQI-80: removed setting locked password if nothing is passed in password NOT TO MERGE - CQI-80: OWASP A07:2021-Identification and Authentication Failures - openimis-be-core_py BE Oct 18, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 2 Security Hotspots
Code Smell A 145 Code Smells

67.3% 67.3% Coverage
1.1% 1.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sniedzielski sniedzielski changed the title NOT TO MERGE - CQI-80: OWASP A07:2021-Identification and Authentication Failures - openimis-be-core_py BE CQI-80: OWASP A01:2021-Broken Access Control - openimis-be-core_py BE Oct 18, 2023
@sniedzielski sniedzielski marked this pull request as ready for review October 18, 2023 10:28
@dborowiecki dborowiecki merged commit 316aa3d into develop Oct 19, 2023
@dborowiecki dborowiecki deleted the feature/CQI-80 branch October 19, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants