-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: allow single CC/BCC recipient to be sent via form-data #2286
Fix: allow single CC/BCC recipient to be sent via form-data #2286
Conversation
Thanks @kevinkim-ogp! I ran your branch on my local machine and specifying I'll take a look at the code right now. |
backend/src/email/routes/tests/email-transactional.routes.test.ts
Outdated
Show resolved
Hide resolved
backend/src/email/routes/tests/email-transactional.routes.test.ts
Outdated
Show resolved
Hide resolved
backend/src/email/routes/tests/email-transactional.routes.test.ts
Outdated
Show resolved
Hide resolved
backend/src/email/routes/tests/email-transactional.routes.test.ts
Outdated
Show resolved
Hide resolved
backend/src/email/routes/tests/email-transactional.routes.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @kevinkim-ogp! Just need a bit of tidying up on your end and then this should be good to go.
backend/src/email/routes/tests/email-transactional.routes.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will let you know once we get this deployed
Problem
Unable to send a single CC/BCC recipient when calling the transactional email API with form-data. This appears to be an edge case, as there are no issues when sending multiple CC/BCC recipients using form-data.
Note: Postman requires attachments to be sent via form-data
Related issue highlighted by another user: #2140
Solution
Enhance current CC/BCC validation to accept stringified arrays.
This change ensures: