chore: remove record log and turn on dbm propagation #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KishenKumarrrrr
had a problem deploying
to
staging
GitHub Actions
Failure
jia1
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Thank you, @KishenKumarrrrr. There's a 2nd log statement that is taking up time too. Will you be finding that statement, or just dealing with this one alone is sufficient enough?
Update: We sync-ed up and concluded that we should deal with this more resource-intensive log statement first before tackling the next.
KishenKumarrrrr
deleted the
refactor/remove-logging-in-email-callback-flow
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is a continuation of #2283. The profile from the latest callback spike indicates that the logging statement in the callback flow is introducing a significant bottleneck to our processing. This could be explained by the log statement that attempts to log out the entire record that is returned to us by SNS.
Solution
In this PR, I avoid logging out the entire record in an attempt to remove the above-mentioned bottleneck. Additionally, I also set
dbmPropagationMode: 'full'in our tracers so that we can retrieve explain plans of the SQL statements we are executing in the future. Based on the traces, the DB query is the next potential bottleneck in the execution and generating data on its performance will allow us to optimise in the future.