refactor: remove SGID login #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia1
reviewed
May 3, 2024
jia1
approved these changes
May 3, 2024
|
@KishenKumarrrrr could you share more about the delay in POCDEX updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In this PR, I remove SGID login from our application. The team came to this decision after learning that POCDEX was returning employee information of former employees. Since support for POCDEX has ceased, we decided that the best thing to do was to drop support for this login flow.
Solution
I've removed all mention to SGID except for in the infra folder. Deleting secrets from infra can be tricky and we should focus on preventing login via SGID first.
When users click on the Singpass button, they will be greeted by the following modal