feat: csv upload via be #2242
Open
feat: csv upload via be #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia1
reviewed
Feb 14, 2024
| withCredentials: false, | ||
| }) | ||
| // 4. Return the etag and transactionId to the FE | ||
| const formattedEtag = removeFirstAndLastCharacter(response.headers.etag) |
There was a problem hiding this comment.
Why do you do this, is it because:
Removing the first and last character from an ETag is a common technique used to address caching issues. ETags are used in HTTP headers to help with web caching. By removing the first and last character, your friend might be attempting to modify the ETag in order to force a cache revalidation. This can be useful when there are issues with caching and the content is not being updated as expected.
jia1
reviewed
Feb 14, 2024
| @@ -63,19 +63,20 @@ async function getMd5(blob: Blob): Promise<string> { | |||
|
|
|||
| export async function uploadFileWithPresignedUrl( | |||
| uploadedFile: File, | |||
| presignedUrl: string | |||
| ): Promise<string> { | |||
| _presignedUrl: string // Making this unused because the endpoint below generates its own presignedUrl and uploads the file | |||
There was a problem hiding this comment.
s2pid qn: Why dowan reuse _presignedUrl?
jia1
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
GSIB users on certain networks are still unable to upload CSV files.
This PR includes a fix that uses the BE to bypass the whitelisting.