Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove .env value #2230

Merged
merged 1 commit into from
Sep 27, 2023
Merged

refactor: remove .env value #2230

merged 1 commit into from
Sep 27, 2023

Conversation

KishenKumarrrrr
Copy link
Contributor

Problem

We no longer need the SGID_VALID_DOMAINS env var so we can remove it.

Deployment Checklist

  • Delete var from production
  • Delete var from staging

@KishenKumarrrrr KishenKumarrrrr self-assigned this Sep 27, 2023
@KishenKumarrrrr KishenKumarrrrr merged commit efa348d into master Sep 27, 2023
@KishenKumarrrrr KishenKumarrrrr deleted the refactor/remove-sgid-valid-domains branch September 27, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jia1 jia1 jia1 approved these changes

Assignees

@KishenKumarrrrr KishenKumarrrrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KishenKumarrrrr @jia1