Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide index page #992

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: hide index page #992

wants to merge 1 commit into from

Conversation

seaerchin
Copy link
Contributor

Problem

index pages display in the sidebar but not in the main view - we should not be showing such index pages for reasons outlined here

Solution

  1. update typing using Exclude in router method
  2. add filter for IndexPage

Tests

  1. add a custom index page in db
  2. verify that this cannot be seenin the sidebar

@seaerchin seaerchin requested a review from a team as a code owner January 15, 2025 09:15
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 15, 2025 •
edited
Loading

Datadog Report

Branch report: fix/hide-index
Commit report: 9137acc
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 47.98s Total Time
➡️ Test Sessions change in coverage: 1 no change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @dcshzj