Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty results message is at a wrong position in blog layout #989

Conversation

sehyunidaaa
Copy link
Contributor

Problem

image

Visual jank, the no results message should be center-aligned to the entire results area. Currently it's on the left column.

After:

Storybook screen capture for blog layout story:
image

@sehyunidaaa sehyunidaaa requested a review from a team as a code owner January 14, 2025 11:58
Copy link

linear bot commented Jan 14, 2025

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 14, 2025

Datadog Report

Branch report: sehyun/iso-165-bug-no-results-in-collection-is-shown-on-left-column
Commit report: 7b33f28
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 46.43s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link
Contributor

@adriangohjw adriangohjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@sehyunidaaa sehyunidaaa enabled auto-merge (squash) January 14, 2025 13:34
@sehyunidaaa sehyunidaaa merged commit a346cf5 into main Jan 14, 2025
18 checks passed
@sehyunidaaa sehyunidaaa deleted the sehyun/iso-165-bug-no-results-in-collection-is-shown-on-left-column branch January 14, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants