Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use permalink for folder settings and not title #983

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

seaerchin
Copy link
Contributor

Problem

Previously, we were using the title of the folder to show in the folder settings modal

Solution

pass the current permalink in so it shows the permalink in the modal

Tests

  1. create a folder at root
  2. update the folder permalink
  3. it should show the new permalink rather than the title
  4. create a folder inside the previous folder
  5. repeat steps 2-3

@seaerchin seaerchin requested a review from a team as a code owner January 13, 2025 06:46
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Jan 13, 2025

Datadog Report

Branch report: fix/folder-permalink
Commit report: 3e2a139
Test service: isomer-studio

✅ 0 Failed, 257 Passed, 36 Skipped, 45.3s Total Time
➡️ Test Sessions change in coverage: 1 no change

@seaerchin seaerchin merged commit ebb5222 into main Jan 15, 2025
16 of 17 checks passed
@seaerchin seaerchin deleted the fix/folder-permalink branch January 15, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants