isom-1709 - chore: do not wrap link text in span #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangohjw
commented
Dec 29, 2024
There was a problem hiding this comment.
this isn't from this PR but thought to commit it in together
Datadog ReportBranch report: ✅ 0 Failed, 245 Passed, 36 Skipped, 49.37s Total Time |
adriangohjw
changed the title
…pdown-link-in-navbar-does-not-have
dcshzj
reviewed
Jan 3, 2025
| @@ -64,9 +64,9 @@ export const NavItem = forwardRef<HTMLButtonElement, NavbarItemProps>( | |||
| isExternal={isExternalUrl(url)} | |||
| showExternalIcon={isExternalUrl(url)} | |||
| href={referenceLinkHref} | |||
| className={item({ isOpen })} | |||
| className={`${item({ isOpen })} ${groupFocusVisibleHighlight()}`} | |||
There was a problem hiding this comment.
issue: I think the group focus visible highlight might need to be replaced with the non-group version (focusVisibleHighlight), as it doesn't work currently (but please verify also):
Screen.Recording.2025-01-03.at.11.07.04.mov
There was a problem hiding this comment.
@dcshzj address in latest commits, thanks!
…lighthouse-seo-non-dropdown-link-in-navbar-does-not-have
dcshzj
approved these changes
Jan 3, 2025
adriangohjw
deleted the
adriangohjw/isom-1709-lighthouse-seo-non-dropdown-link-in-navbar-does-not-have
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes https://linear.app/ogp/issue/ISOM-1709/[lighthouse-seo]-non-dropdown-link-in-navbar-does-not-have-descriptive
Solution
Breaking Changes
Improvements:
<span>