-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests and handling for deleted users #953
base: 12-20-soft_delete_for_user_and_perms
Are you sure you want to change the base?
add tests and handling for deleted users #953
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Datadog ReportBranch report: ✅ 0 Failed, 261 Passed, 36 Skipped, 47.03s Total Time |
23cf858
to
e611093
Compare
apps/studio/src/server/modules/user/__tests__/user.service.test.ts
Outdated
Show resolved
Hide resolved
apps/studio/src/server/modules/user/__tests__/user.service.test.ts
Outdated
Show resolved
Hide resolved
6f97b13
to
11d220c
Compare
e611093
to
70ea755
Compare
Problem
Deleted users were still able to access the system and view sites they previously had access to.
Closes ISOM-1701
Solution
Added checks to prevent deleted users from logging in and viewing sites they previously had access to.
Breaking Changes:
Features:
Improvements:
Tests
New scripts:
None
New dependencies:
None
New dev dependencies:
None