Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isloading #951

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: isloading #951

merged 1 commit into from
Dec 23, 2024
+1 −1

Conversation

seaerchin
Copy link
Contributor

Problem

Loading state for button on root page was stuck in loading

Solution

  1. set the isLoading state to be preferentially from isLoading and fallback to isLoadingPermalink only if folderId is defined

Checks

  1. create a page at root
  2. make sure that you can create such a page

@seaerchin seaerchin requested a review from a team as a code owner December 20, 2024 09:07
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 20, 2024 •
edited
Loading

Datadog Report

Branch report: fix/loading-statse
Commit report: 4f02bfa
Test service: isomer-studio

✅ 0 Failed, 245 Passed, 36 Skipped, 50.43s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw merged commit 3297d32 into main Dec 23, 2024
25 of 26 checks passed
@adriangohjw adriangohjw deleted the fix/loading-statse branch December 23, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangohjw adriangohjw adriangohjw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @adriangohjw