fix - add tooltip for navbar logo #945
Merged
+33
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 245 Passed, 36 Skipped, 47.95s Total Time |
harishv7
reviewed
Dec 20, 2024
| /> | ||
| } | ||
| /> | ||
| <Tooltip label={"Back to sites"} placement="right"> |
There was a problem hiding this comment.
Will this also show on the "All sites" page? That might be confusing
There was a problem hiding this comment.
It does. Currently there's already an existing link to do that without the tooltip, so IMO not adding can be more confusing because users click and "nothing happens". Perhaps a better improvement is to remove the link altogether?
There was a problem hiding this comment.
updated for homepage to not be a button and not be clickable
…issing-tooltip-label-for-navbar-logo
…issing-tooltip-label-for-navbar-logo
dcshzj
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
isomer logo in studio navbar is missing tooltip on hover
Solution
Breaking Changes
Bug Fixes:
Before & After Screenshots
BEFORE:
AFTER: