Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add placeholder for article summary #943

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

adriangohjw
Copy link
Contributor

Problem

Collection (article page header) can be saved when article summary is required.

This is because we set it to be an empty string by default, which technically passes the validation

However, this is not aligned with the gold standards as we want users to provide this value

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Bug Fixes:

  • set a default non-empty string value

Before & After Screenshots

BEFORE:

image

AFTER:

image

@adriangohjw adriangohjw added the bug Something isn't working label Dec 19, 2024
@adriangohjw adriangohjw self-assigned this Dec 19, 2024
@adriangohjw adriangohjw requested a review from a team as a code owner December 19, 2024 17:34
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 19, 2024

Datadog Report

Branch report: fix-empty-article-summary
Commit report: 90e166d
Test service: isomer-studio

✅ 0 Failed, 232 Passed, 36 Skipped, 38s Total Time
➡️ Test Sessions change in coverage: 1 no change

@adriangohjw adriangohjw merged commit 7adf76d into main Dec 20, 2024
17 checks passed
@adriangohjw adriangohjw deleted the fix-empty-article-summary branch December 20, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants