Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: collections active state #941

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: collections active state #941

merged 1 commit into from
Dec 20, 2024

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Dec 19, 2024 •
edited
Loading

Problem

we were previously using the wrong property, leading to collections not having the correct state in side bar when we are already in the collection

Solution

update to correct property

Checks

  1. Click into a collection
  2. the sidebar should be highlighted for the collection

@seaerchin seaerchin requested a review from a team as a code owner December 19, 2024 13:10
@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Dec 19, 2024 •
edited
Loading

Datadog Report

Branch report: fix/collections-active-state
Commit report: 5253562
Test service: isomer-studio

✅ 0 Failed, 232 Passed, 36 Skipped, 40.04s Total Time
➡️ Test Sessions change in coverage: 1 no change

harishv7
harishv7 reviewed Dec 19, 2024
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
harishv7
harishv7 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@harishv7 harishv7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with 1 minor comment

@seaerchin seaerchin force-pushed the fix/collections-active-state branch from 7c27f06 to 15b6c37 Compare December 20, 2024 02:46
@seaerchin seaerchin enabled auto-merge (squash) December 20, 2024 02:46
@seaerchin seaerchin merged commit 6dfb9c8 into main Dec 20, 2024
16 of 17 checks passed
@seaerchin seaerchin deleted the fix/collections-active-state branch December 20, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishv7 harishv7 harishv7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seaerchin @harishv7