isom-1689 polish for component editing panels #920
Merged
+313
−532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Datadog ReportBranch report: ✅ 0 Failed, 232 Passed, 36 Skipped, 40.6s Total Time 🔻 Code Coverage Decreases vs Default Branch (1)
|
|
@jandonyada fixed storybook |
…ngohjw/isom-1689-polish-for-component-editing-panels
seaerchin
reviewed
Dec 17, 2024
...c/features/editing-experience/components/form-builder/renderers/controls/BaseLinkControl.tsx
Show resolved
Hide resolved
.../editing-experience/components/form-builder/renderers/controls/JsonFormsUnionRootControl.tsx
Outdated
Show resolved
Hide resolved
|
add a link to refactor: https://linear.app/ogp/issue/ISOM-1703/refactor-link-editor |
…ngohjw/isom-1689-polish-for-component-editing-panels
seaerchin
approved these changes
Dec 20, 2024
adriangohjw
deleted the
adriangohjw/isom-1689-polish-for-component-editing-panels
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes https://linear.app/ogp/issue/ISOM-1689/polish-for-component-editing-panels except the tiptap editor changes which will handled in a separate PR due to the complexity of having to overwrite tiptap default settings
Solution
Breaking Changes
Improvements:
JsonFormsUnionRootControlwhich handles empty Control block when usingUniontypeJsonFormsLinkControl) to useBaseLinkControl- which was extracted fromJsonFormsRefControl- note: this PR does not refactor away this code and there seems to require more work, which isn't the priority at the momentAltTextSchemaandImageSrcSchemato be reused for consistency of the descriptions and single source of truthTests
please check against the list in the notion of the linear ticket (those labelled 1️⃣ )