feat: set up S3 connector to get presigned PUT URL #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seaerchin
approved these changes
Aug 6, 2024
| // NOTE: We're using a random folder name to prevent collisions | ||
| const folderName = randomUUID() | ||
|
|
||
| return `${siteId}/${folderName}/${fileName}` |
There was a problem hiding this comment.
hwy not just use the resource id since it's guaranteed to be unique
There was a problem hiding this comment.
Hmm this is the asset itself and it's possible to have multiple images within the same page resource, so will need a more globally unique ID.
dcshzj
force-pushed
the
feat/get-presigned-put
branch
from
1bcdbf1 to
f4f1e5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't have a proper S3 connector to handle asset uploading.
Solution
Breaking Changes
Features:
${siteId}/${UUID}/${fileName}.