Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): use desktop breakpoint as default chromatic snapshot #431

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 5, 2024

TL;DR

Add chromatic modes support to Storybook preview configuration for better visual test coverage.

What changed?

  • Imported withChromaticModes from @isomer/storybook-config
  • Modified the Storybook preview configuration to include chromatic mode settings.
  • Updated documentation to guide adding chromatic mode in a per-story basis.
  • Set default chromatic mode to 'desktop' with prefer-reduced-motion to 'reduce'.

How to test?

  1. Run Storybook
  2. Verify the chromatic mode is applied correctly for stories.

Why make this change?

To improve visual test coverage and ensure components behave correctly across different viewing modes.


Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2024 3:09pm

Copy link
Contributor Author

karrui commented Aug 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @karrui and the rest of your teammates on Graphite Graphite

@karrui karrui changed the title feat: use desktop breakpoint as default chromatic snapshot feat(components: use desktop breakpoint as default chromatic snapshot Aug 5, 2024
@karrui karrui changed the title feat(components: use desktop breakpoint as default chromatic snapshot feat(components): use desktop breakpoint as default chromatic snapshot Aug 5, 2024
@karrui karrui marked this pull request as ready for review August 5, 2024 14:55
@karrui karrui requested a review from a team as a code owner August 5, 2024 14:55
@karrui karrui merged commit f017263 into main Aug 7, 2024
14 of 16 checks passed
@karrui karrui deleted the default_chromatic_snapshots_to_desktop_view branch August 7, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants