feat: replace hard-coded color values with (hardcoded) CSS variables from site theme #404
+79
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little complex, see if it makes sense.
the main thing is isomer-components export a tailwind plugin that basically takes in a json object of colors to inject into
:root
. But onlytemplate
needs it. The rest will inject css vars with their various implementation.TL;DR
Migrated brand colors to CSS variables and introduced a new
isomerSiteTheme
plugin for (future) dynamic theme injection.What changed?
colors.ts
to use CSS variables for brand colors.isomerSiteTheme
insite-theme.ts
to dynamically inject CSS variables.index.ts
and integrated the newisomerSiteTheme
plugin.How to test?
Should have no changes for components that were already using the previously (more) hardcoded tokens.
Why make this change?
This change is motivated by the need for better theme management and dynamic theming capabilities using CSS variables.