Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set fullscreen layout and remove autodocs for layout stories #384

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Jul 29, 2024

TL;DR

Updated the Storybook layouts to include fullscreen parameter and autodocs tags for template layouts that should be in fullscreen.

What changed?

  • Added layout: fullscreen parameter to the meta object for Article, Collection, Content, Homepage, NotFound, and Search story files.
  • Added tags: ['!autodocs'] to the meta object for the same story files.
  • Updated the names of the default stories to match their corresponding layout names.

How to test?

  1. Run Storybook.
  2. Verify that the specified stories are displayed in fullscreen.
  3. Check that the tags for autodocs are present.

Why make this change?

To ensure consistency across the Storybook layouts and make use of the fullscreen parameter and autodocs tags for better documentation and presentation.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 6:07am

Copy link
Contributor Author

karrui commented Jul 31, 2024

Merge activity

  • Jul 31, 2:00 AM EDT: @karrui started a stack merge that includes this pull request via Graphite.
  • Jul 31, 2:01 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 31, 2:08 AM EDT: @karrui merged this pull request with Graphite.

Base automatically changed from karrui/isom-1266-navigation-bar-styling-and-behaviour-changes to main July 31, 2024 06:00
@karrui karrui force-pushed the update_layout_stories branch from 4a86916 to 1bc41c7 Compare July 31, 2024 06:01
@karrui karrui merged commit 200f821 into main Jul 31, 2024
16 of 17 checks passed
@karrui karrui deleted the update_layout_stories branch July 31, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants