feat: add new 'minus' icon and update TableOfContents component #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samanthadotdesign
commented
Jul 26, 2024
samanthadotdesign
commented
- Added new minus icon for list item from BoxIcon
- Updated typography and semantic colour tokens
- Changed underline on hover with underline offset
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
samanthadotdesign
temporarily deployed
to
staging
GitHub Actions
Inactive
karrui
changed the title
dcshzj
reviewed
Jul 29, 2024
| {items.map(({ anchorLink, content }) => ( | ||
| <div className="flex flex-row items-start gap-2"> | ||
| <BiRightArrowAlt className="size-6 shrink-0 text-interaction-main" /> | ||
| <BiMinus className="size-5 shrink-0 fill-base-content-strong" /> |
There was a problem hiding this comment.
issue: I think the minus sign is not middle aligned
| @@ -31,4 +33,5 @@ export const SUPPORTED_ICONS_MAP: Record<SupportedIconName, SupportedIconType> = | |||
| "office-building": BiBuildings, | |||
| stars: BiStar, | |||
| globe: BiGlobe, | |||
| minus: BiMinus, | |||
There was a problem hiding this comment.
question: hmm the icon here means that we are making it available for users to use this icon (for instance in infocols), is this intended?
dcshzj
approved these changes
Aug 6, 2024
sehyunidaaa
deleted the
samanthalee/isom-1279-tableofcontents-styling-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.