Skip to content

Commit

Permalink
refactor: logocloud
Browse files Browse the repository at this point in the history
don't ask consumers for assetsbaseurl but ask for site instead
  • Loading branch information
seaerchin committed Dec 26, 2024
1 parent 0450936 commit f7bc6e4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions packages/components/src/interfaces/complex/LogoCloud.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { Static } from "@sinclair/typebox"
import { Type } from "@sinclair/typebox"

import { IsomerSiteProps } from "~/types"

Check warning on line 4 in packages/components/src/interfaces/complex/LogoCloud.ts

View workflow job for this annotation

GitHub Actions / lint

All imports in the declaration are only used as types. Use `import type`
import { AltTextSchema, ImageSrcSchema } from "./Image"

export const LOGO_CLOUD_TYPE = "logocloud"
Expand All @@ -25,10 +26,10 @@ export const LogoCloudSchema = Type.Object(
}),
},
{
title: "Title",
title: "Logocloud component",
},
)

export type LogoCloudProps = Static<typeof LogoCloudSchema> & {
assetsBaseUrl?: string
site: IsomerSiteProps
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { ImageClient } from "../Image"
export const LogoCloud = ({
images: baseImages,
title,
assetsBaseUrl,
site: { assetsBaseUrl },
}: LogoCloudProps) => {
const images = baseImages.map(({ src, alt }) => {
const transformedSrc =
Expand Down

0 comments on commit f7bc6e4

Please sign in to comment.