Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve validation for OtpForm and LoginForm #1271

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: improve validation for OtpForm and LoginForm #1271

wants to merge 1 commit into from

Conversation

zxt-tzx
Copy link
Contributor

@zxt-tzx zxt-tzx commented Apr 14, 2022

While working on opengovsg/CheckWho#251, thought to transpose the code changes to checkfirst.

Advantages:

  • More stringent frontend validation for email; must be @.gov.sg email, and not just any email
  • Error case looks more aesthetic using react-hook-form and Chakra UI's FormControl, compared to default HTML

BEFORE:
SCR-20220414-uqh
image

AFTER:
SCR-20220414-st9

@zxt-tzx zxt-tzx requested a review from lamkeewei April 14, 2022 14:10
LoneRifle
LoneRifle requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@LoneRifle LoneRifle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tan-zx - given that we allow other quasi-government institutions to use CheckFirst (most notably the medical clusters), could you take the trouble to rework this PR so that we only take on board the OTP validation? Thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoneRifle LoneRifle LoneRifle requested changes

@lamkeewei lamkeewei Awaiting requested review from lamkeewei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxt-tzx @LoneRifle