Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release v6.160.0 #7873

Merged
merged 9 commits into from
Nov 11, 2024
Merged

build: release v6.160.0 #7873

merged 9 commits into from
Nov 11, 2024

Conversation

kevin9foong
Copy link
Contributor

@kevin9foong kevin9foong commented Nov 11, 2024

New

  • fix: make children body input components controlled from the start #7871
  • feat(i18n): add en-sg locale for AddRowFooter #7867
  • fix: drawer date picker invalid selection bug #7866
  • fix: add validation rules to controller #7874

Dependencies

  • fix(deps): bump libphonenumber-js from 1.11.13 to 1.11.14 in /shared #7872
  • fix(deps): bump libphonenumber-js from 1.11.12 to 1.11.13 in /shared #7858

Dev-Dependencies

Tests

fix: make children body input components controlled from the start #7871

Regression on myinfo child fields combo box data
  • Create an email mode form + all child fields + some other fields (eg, short text, checkbox)
  • Make a submission to the field on mobile as a respondent, try to fill up the different child fields and change children etc.
  • Repeat submission 2-3 times and ensure that the submission does not hang.

fix: add validation rules to controller #7874

myinfo child fields are properly validated as required by the FE.

  • Create a myinfo child field with all subfields
  • Submit the form and leave it empty, ensure that the required FE validation error message is shown for all fields
  • select a child which does prefill -> ensure that the prefilled fields no longer have an error
  • submit and notice that secondary race which is not prefilled still has a required error
  • fill it up and submit -> ensure that it works fine

fix: drawer date picker invalid selection bug #7866

date reflects correctly after custom date range selection:

  • Create a storage mode form with form field
  • Select custom date validation and check the range on the form field builder is correct when the drawer is extended.
  • Save the form field setting.
  • Try to preview the form and check the date field. ensure the valid date range is correct.
  • Try to submit the form and check the date field. ensure the valid date range is correct.

dependabot bot and others added 5 commits November 7, 2024 16:37
…7858)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.12 to 1.11.13.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/compare/v1.11.12...v1.11.13)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge release v6.159.0 to develop
Extract text from AddRowFooter into a locale, rewording as needed
to suit. Ensure that we honour the use of ICU conventions for plurals
…7872)

Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.11.13 to 1.11.14.
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/commits/master)

---
updated-dependencies:
- dependency-name: libphonenumber-js
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: normalize date to utc from EditDate input
* fix: add validation rules to subfields and name field

* fix: name the index as child name index
@kevin9foong kevin9foong merged commit 3c3c91c into release-al2 Nov 11, 2024
44 of 46 checks passed
@kevin9foong kevin9foong deleted the release_v6.160.0 branch November 11, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants