Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: package cleanup #7141

Merged
merged 6 commits into from
Mar 19, 2024
Merged

chore: package cleanup #7141

merged 6 commits into from
Mar 19, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Mar 18, 2024

Problem

Some packages are no longer used, or is outdated.
Cleaning up to remove false positives from snyk / dependabot.
Partial cleanup referenced from https://www.notion.so/opengov/Clean-up-Dependecies-543f14a586cd4e4ca0d764d56bc480f1?pvs=4

Solution

  • "html-loader": "~0.5.5",: no longer used in webpack
  • "ngrok": no longer used in e2e tests
  • "proxyrequire": no longer used in e2e tests
  • "file-loader": no longer used in webpack
  • "css-loader": no longer used in webpack
  • "url-loader": no longer used in webpack
  • "@types/has-ansi": no longer used in logger (has-ansi)
  • "css-toggle-switch": no longer referenced in public/main
  • "ui-select": no longer using angular

@KenLSM KenLSM force-pushed the chore/package-cleanup branch from b5dd55b to d353080 Compare March 18, 2024 14:02
@KenLSM KenLSM requested a review from kathleenkhy March 18, 2024 15:11
@KenLSM KenLSM requested a review from justynoh March 19, 2024 05:35
Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@justynoh justynoh merged commit 770d28f into develop Mar 19, 2024
23 checks passed
@justynoh justynoh deleted the chore/package-cleanup branch March 19, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants