-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dd): link source code to dd #7120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KenLSM
force-pushed
the
chore/dd-code-integration
branch
from
March 5, 2024 08:46
ea1c860
to
e03fda9
Compare
KenLSM
force-pushed
the
chore/dd-code-integration
branch
from
March 5, 2024 09:58
e03fda9
to
7f10572
Compare
@wanlingt this might be useful for Signify as reference! |
justynoh
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Source Code is not linked to DD. Having this link would help us to identify the likely line of code that has caused the error.
Solution
To include DD variables into
env
that dd would load on init ..ebextensions/env-file-creation.config
to.ebextensions/01env-file-aws-ssm.config
.ebextensions/02env-file-datadog.config
Notes
The file starts with 01 as
eb
will run the scripts in order of alphabetical order. i.e.,01*.config
runs before02*.config
.env
is created/overwritten in01*.config
while.ebextensions/02env-file-datadog.config
append the new envvars into.env
directly. Thus, we have to ensure that.ebextensions/01env-file-aws-ssm.config
gets executed first.Breaking Changes
Tests
Regression