Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dd): link source code to dd #7120

Merged
merged 8 commits into from
Mar 18, 2024
Merged

chore(dd): link source code to dd #7120

merged 8 commits into from
Mar 18, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Mar 4, 2024

Problem

Source Code is not linked to DD. Having this link would help us to identify the likely line of code that has caused the error.

Solution

To include DD variables into env that dd would load on init .

DD_GIT_COMMIT_SHA="<commitSha>"
DD_GIT_REPOSITORY_URL="<gitRepo>"
  1. Rename .ebextensions/env-file-creation.config to .ebextensions/01env-file-aws-ssm.config
  2. Add .ebextensions/02env-file-datadog.config

Notes
The file starts with 01 as eb will run the scripts in order of alphabetical order. i.e., 01*.config runs before 02*.config

.env is created/overwritten in 01*.config while .ebextensions/02env-file-datadog.config append the new envvars into .env directly. Thus, we have to ensure that .ebextensions/01env-file-aws-ssm.config gets executed first.

Breaking Changes

  • No - this PR is backwards compatible

Tests

Regression

  • Make a Form Submission
  • Observe that it succeeds

@KenLSM KenLSM changed the title add env vars to docker chore(dd): link source code to dd Mar 4, 2024
@KenLSM KenLSM force-pushed the chore/dd-code-integration branch from e03fda9 to 7f10572 Compare March 5, 2024 09:58
@KenLSM KenLSM requested review from justynoh and sebastianwzq March 5, 2024 10:52
@KenLSM
Copy link
Contributor Author

KenLSM commented Mar 5, 2024

@wanlingt this might be useful for Signify as reference!

@wanlingt
Copy link
Contributor

wanlingt commented Mar 6, 2024

@wanlingt this might be useful for Signify as reference!

thanks @KenLSM !!

Copy link
Contributor

@justynoh justynoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KenLSM KenLSM merged commit b9c6e57 into develop Mar 18, 2024
19 checks passed
@KenLSM KenLSM deleted the chore/dd-code-integration branch March 18, 2024 05:43
@KenLSM KenLSM mentioned this pull request Mar 19, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants