Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v6.87.0 #6878

Merged
merged 5 commits into from
Nov 8, 2023
Merged

build: release v6.87.0 #6878

merged 5 commits into from
Nov 8, 2023

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Nov 8, 2023 •
edited
Loading

New

  • fix: encode product name and log error #6877
  • fix: format Announcement Modal #6868
  • fix: add case for SGID MyInfo when field value is missing #6874
  • build: merge release v6.86.0 into develop #6873
  • build: release v6.86.0 #6866

Dependencies

Dev-Dependencies

Tests

fix: encode product name and log error #6877

Deploy Notes

New environment variables:

  • env var : env var details

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details

fix: format Announcement Modal #6868

@KenLSM

  • Go to the formsg dashboard page. Open the inspector tool, go to local storage and delete has-seen-rollout-announcement-20231026-62d5280a4a8ff8005e51999a. The rollout announcement modal should appear
  • The modal should have slightly rounded edges and there should be a space above the announcement graphic on each page (as in the screenshot)

fix: add case for SGID MyInfo when field value is missing #6874

(Could not be tested on stg as we do not have sgid stg profile on stg)
Singpass MyInfo

  • Submit a Singpass MyInfo form that contains the MyInfo nationality field
  • Check that the field is not logged in error logs (search for meta.action like 'prefillAndSaveMyInfoFields')

SGID MyInfo

  • Submit a SGID MyInfo form that contains the MyInfo nationality field
  • Check that the field is not logged in error logs (search for meta.action like 'prefillAndSaveMyInfoFields')

KenLSM and others added 5 commits November 7, 2023 12:16
@KenLSM
Merge pull request #6873 from opengovsg/release-al2
f512cb9 
build: merge release v6.86.0 into develop
@wanlingt
fix: add case for SGID MyInfo when field value is missing (#6874)
28cfa54 
* fix: add case for SGID MyInfo

* fix: add an early return
@wanlingt
fix: format Announcement Modal (#6868)
005e57f 
* fix: add border radius and use box for image

* fix: use svg instead of json for payments graphic
@sebastianwzq @tshuli
fix: encode product name and log error (#6877)
ded7341 
* fix: encode product name and log error

* fix: remove overly defensive coding

* chore: add optional

* chore: add empty fallback

---------

Co-authored-by: tshuli <[email protected]>
@tshuli
chore: bump version to v6.87.0
5054803
KenLSM
KenLSM approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tshuli tshuli merged commit b3f07f1 into release-al2 Nov 8, 2023
45 checks passed
@tshuli tshuli deleted the release_v6.87.0 branch November 8, 2023 08:02
@wanlingt wanlingt mentioned this pull request Nov 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenLSM KenLSM KenLSM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tshuli @KenLSM @wanlingt @sebastianwzq