Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotfix v6.85.1 to prevent creation of SGID_MyInfo storage mode forms #6860

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix: hotfix v6.85.1 to prevent creation of SGID_MyInfo storage mode forms #6860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5e6a70
fix: add validation check for SGID_MyInfo
wanlingt Oct 31, 2023
6b0fbeb
chore: bump version to 6.85.1
wanlingt Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [v6.85.1](https://github.com/opengovsg/FormSG/compare/v6.85.0...v6.85.1)

- build: release v6.85.0 [`#6857`](https://github.com/opengovsg/FormSG/pull/6857)
- fix: add validation check for SGID_MyInfo [`c5e6a70`](https://github.com/opengovsg/FormSG/commit/c5e6a70764d5229a36985b363cc4695e49dfad6d)

#### [v6.85.0](https://github.com/opengovsg/FormSG/compare/v6.84.0...v6.85.0)

> 30 October 2023

- fix(workspaces): remove form from collab workspace [`#6843`](https://github.com/opengovsg/FormSG/pull/6843)
- feat(workspaces): folders [`#6856`](https://github.com/opengovsg/FormSG/pull/6856)
- fix: use secret to sign and verify sgid jwt [`#6845`](https://github.com/opengovsg/FormSG/pull/6845)
Expand All @@ -14,6 +21,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
- chore(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 [`#6851`](https://github.com/opengovsg/FormSG/pull/6851)
- build: merge release v6.84.0 into develop [`#6847`](https://github.com/opengovsg/FormSG/pull/6847)
- build: release v6.84.0 [`#6846`](https://github.com/opengovsg/FormSG/pull/6846)
- chore: bump version to v6.85.0 [`80c1645`](https://github.com/opengovsg/FormSG/commit/80c1645309dfe0df0604d635b21c767f56088f25)

#### [v6.84.0](https://github.com/opengovsg/FormSG/compare/v6.83.0...v6.84.0)

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "FormSG",
"description": "Form Manager for Government",
"version": "6.85.0",
"version": "6.85.1",
"homepage": "https://form.gov.sg",
"authors": [
"FormSG <[email protected]>"
Expand Down
2 changes: 1 addition & 1 deletion src/app/models/form.server.model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ const compileFormModel = (db: Mongoose): IFormModel => {
} else if (
this.responseMode === FormResponseMode.Encrypt &&
// MyInfo is not available for storage mode
v === FormAuthType.MyInfo
(v === FormAuthType.MyInfo || v === FormAuthType.SGID_MyInfo)
) {
return FormAuthType.NIL
} else {
Expand Down
Loading