Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reinstate feedback rating to DD #6388

Merged
merged 3 commits into from
May 25, 2023
Merged

Conversation

LinHuiqing
Copy link
Contributor

Problem

Sending of feedback rating to datadog was mistakenly removed in our process of removing angular in #6347 (code snippet: https://github.com/opengovsg/FormSG/pull/6347/files#diff-c78d0fec54621dd34024ef099947b4e2e923666ccf65b1c80dc6e34ab8beb053L6-L68).

Solution

Reinstate statsdClient to send feedback rating data to datadog.

Breaking Changes

  • No - this PR is backwards compatible

@LinHuiqing LinHuiqing merged commit 08de75c into develop May 25, 2023
@LinHuiqing LinHuiqing deleted the fix/feedback-rating branch May 25, 2023 16:43
@timotheeg timotheeg mentioned this pull request May 26, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants