Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release 6.50.0 hotfix #6349

Closed
wants to merge 1 commit into from
Closed

Conversation

LinHuiqing
Copy link
Contributor

@LinHuiqing LinHuiqing commented May 18, 2023

Problem

  • In release 6.50.0, we introduced a bug (f4f5998) where payment-related copy meant for non-production environments shown on production environments.
  • This PR fixes it by making the SECRET_ENV environment variable accessible on frontend through useEnv.

Tests

  • On a storage-mode form that does not have payments enabled, go to payment settings page and check that the copy is correct and links to the guide.
  • When the SECRET_ENV is set as production:
    • Go to a storage-mode form with payment enabled and preview the form. There should be a banner and check that the copy is expected as above.
    • Go to a storage-mode form with payment enabled, open the form and try to pay as a respondent. On the payment page, check that there is no infobox above the payment element.
  • When the SECRET_ENV is not set as production (e.g. staging):
    • Go to a storage-mode form with payment enabled and preview the form. There should be a banner and check that the copy is expected as above.
    • Go to a storage-mode form with payment enabled, open the form and try to pay as a respondent. On the payment page, check that there is an infobox with the expected copy on the test card.

@LinHuiqing LinHuiqing changed the base branch from develop to release-al2 May 18, 2023 05:51
@LinHuiqing LinHuiqing changed the title fix: take frontend env var for payment copy build: release 6.50.0 hotfix May 18, 2023
@LinHuiqing LinHuiqing closed this May 18, 2023
@LinHuiqing LinHuiqing deleted the fix/payment-prod-copy branch May 18, 2023 06:07
@mergify
Copy link

mergify bot commented May 18, 2023

⚠️ The sha of the head commit of this PR conflicts with #6350. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant