Skip to content

Commit

Permalink
Merge pull request #6860 from opengovsg/release-v6.85.1
Browse files Browse the repository at this point in the history
fix: hotfix v6.85.1 to prevent creation of SGID_MyInfo storage mode forms
  • Loading branch information
wanlingt authored Oct 31, 2023
2 parents 9bd11db + 6b0fbeb commit 9176cdb
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,15 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [v6.85.1](https://github.com/opengovsg/FormSG/compare/v6.85.0...v6.85.1)

- build: release v6.85.0 [`#6857`](https://github.com/opengovsg/FormSG/pull/6857)
- fix: add validation check for SGID_MyInfo [`c5e6a70`](https://github.com/opengovsg/FormSG/commit/c5e6a70764d5229a36985b363cc4695e49dfad6d)

#### [v6.85.0](https://github.com/opengovsg/FormSG/compare/v6.84.0...v6.85.0)

> 30 October 2023

- fix(workspaces): remove form from collab workspace [`#6843`](https://github.com/opengovsg/FormSG/pull/6843)
- feat(workspaces): folders [`#6856`](https://github.com/opengovsg/FormSG/pull/6856)
- fix: use secret to sign and verify sgid jwt [`#6845`](https://github.com/opengovsg/FormSG/pull/6845)
Expand All @@ -14,6 +21,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
- chore(deps-dev): bump browserify-sign from 4.2.1 to 4.2.2 [`#6851`](https://github.com/opengovsg/FormSG/pull/6851)
- build: merge release v6.84.0 into develop [`#6847`](https://github.com/opengovsg/FormSG/pull/6847)
- build: release v6.84.0 [`#6846`](https://github.com/opengovsg/FormSG/pull/6846)
- chore: bump version to v6.85.0 [`80c1645`](https://github.com/opengovsg/FormSG/commit/80c1645309dfe0df0604d635b21c767f56088f25)

#### [v6.84.0](https://github.com/opengovsg/FormSG/compare/v6.83.0...v6.84.0)

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "FormSG",
"description": "Form Manager for Government",
"version": "6.85.0",
"version": "6.85.1",
"homepage": "https://form.gov.sg",
"authors": [
"FormSG <[email protected]>"
Expand Down
2 changes: 1 addition & 1 deletion src/app/models/form.server.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ const compileFormModel = (db: Mongoose): IFormModel => {
} else if (
this.responseMode === FormResponseMode.Encrypt &&
// MyInfo is not available for storage mode
v === FormAuthType.MyInfo
(v === FormAuthType.MyInfo || v === FormAuthType.SGID_MyInfo)
) {
return FormAuthType.NIL
} else {
Expand Down

0 comments on commit 9176cdb

Please sign in to comment.