refactor(logic): consolidate logic functions into shared (#7136)

* refactor(logic): consolidate logic functions into shared * test: fix test import paths * chore: add more details to comments, use shared function for isNonEmpty * refactor: move internal radio field constant over to shared as SSOT * chore: add comment to unreachable code path
opengovsg · Mar 19, 2024 · 520c5bf · 520c5bf
1 parent 8c5a160
commit 520c5bf
Show file tree

Hide file tree

Showing 17 changed files with 917 additions and 814 deletions.
diff --git a/frontend/src/features/logic/utils/allConditionsExist.ts b/frontend/src/features/logic/utils/allConditionsExist.ts
diff --git a/frontend/src/features/logic/utils/getLogicUnitPreventingSubmit.tsx b/frontend/src/features/logic/utils/getLogicUnitPreventingSubmit.tsx
diff --git a/frontend/src/features/logic/utils/getVisibleFieldIds.ts b/frontend/src/features/logic/utils/getVisibleFieldIds.ts
diff --git a/frontend/src/features/logic/utils/groupLogicUnitsByField.ts b/frontend/src/features/logic/utils/groupLogicUnitsByField.ts
diff --git a/frontend/src/features/logic/utils/index.ts b/frontend/src/features/logic/utils/index.ts
@@ -1,3 +1,2 @@
 export * from './getIfLogicType'
-export * from './getLogicUnitPreventingSubmit'
-export * from './getVisibleFieldIds'
+export * from './logic-adaptor'