Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings follow-up #104

Merged
merged 1 commit into from
Oct 10, 2024
Merged

settings follow-up #104

merged 1 commit into from
Oct 10, 2024

Conversation

3nids
Copy link
Member

@3nids 3nids commented Oct 9, 2024

following qgis/QGIS#59014

@3nids 3nids requested a review from gacarrillor October 9, 2024 19:17
@3nids 3nids merged commit 153c206 into master Oct 10, 2024
1 of 2 checks passed
@3nids 3nids deleted the settings-fup branch October 10, 2024 03:49
@gacarrillor
Copy link
Contributor

@3nids, not sure if this is related to this PR or to the previous one:

Loading the plugin (version master) on a QGIS master (version qgis/QGIS@f912f78, 10 October) I get this when I go to the QGIS locator and write ch:

2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterWMTS: 'Settings' object has no attribute 'filter_wmts_limit'
2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterLocation: 'Settings' object has no attribute 'filter_location_limit'
2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterWMTS: swiss_locator_filter.py 326
2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterLayer: 'Settings' object has no attribute 'filter_layers_limit'
2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterLocation: swiss_locator_filter.py 326
2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterLayer: swiss_locator_filter.py 326
2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterWMTS: None
2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterLayer: None
2024-10-11T10:24:54     CRITICAL    SwissLocatorFilterLocation: None

The Python console shows the following message:

File "/home/germap/.local/share/QGIS/QGIS3/profiles/test_plugins_2/python/plugins/swiss_locator/core/filters/swiss_locator_filter.py", line 326, in fetchResults
    self.perform_fetch_results(search, feedback)
  File "/home/germap/.local/share/QGIS/QGIS3/profiles/test_plugins_2/python/plugins/swiss_locator/core/filters/swiss_locator_filter.py", line 326, in fetchResults
    self.perform_fetch_results(search, feedback)
  File "/home/germap/.local/share/QGIS/QGIS3/profiles/test_plugins_2/python/plugins/swiss_locator/core/filters/swiss_locator_filter_wmts.py", line 180, in perform_fetch_results
    for result in results[0 : self.settings.filter_wmts_limit.value()]:
  File "/home/germap/.local/share/QGIS/QGIS3/profiles/test_plugins_2/python/plugins/swiss_locator/core/filters/swiss_locator_filter.py", line 326, in fetchResults
    self.perform_fetch_results(search, feedback)
  File "/home/germap/.local/share/QGIS/QGIS3/profiles/test_plugins_2/python/plugins/swiss_locator/core/filters/swiss_locator_filter_location.py", line 61, in perform_fetch_results
    limit = self.settings.filter_location_limit.value()
AttributeError: 'Settings' object has no attribute 'filter_wmts_limit'
  File "/home/germap/.local/share/QGIS/QGIS3/profiles/test_plugins_2/python/plugins/swiss_locator/core/filters/swiss_locator_filter_layer.py", line 56, in perform_fetch_results
    limit = self.settings.filter_layers_limit.value()
AttributeError: 'Settings' object has no attribute 'filter_location_limit'
AttributeError: 'Settings' object has no attribute 'filter_layers_limit'

Am I missing something?

3nids added a commit that referenced this pull request Oct 11, 2024
3nids added a commit that referenced this pull request Oct 12, 2024
* Follow up #104

* Update WMTS and location filter limits (#106)

---------

Co-authored-by: Germap <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants