-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the option for specify the project title on packaged project #615
Adding the option for specify the project title on packaged project #615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of complicating the code in the caller (in this case QFieldSync), we should add this functionality within the OfflineConverter itself. Why? Because the converter already does the copy of the file.
For example here we have hardcoded the name of the output file: https://github.com/opengisch/libqfieldsync/blob/master/libqfieldsync/offline_converter.py#L276
What we can do is to pass the output name to be a parameter when we construct the OfflineConverter
class. We can even replace the export_dir
param with export_filename
param, and then derive the export_dir
to be the path to export_filename
.
Please note that most of the suggestion here need code-wide changes, the suggestions are only pointing to the highlights. |
@suricactus The changes and suggestions were addressed in this PR |
Few comments after the libqfieldsync review:
Please update the screenshot when ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not there yet.
16fe607
to
39ba5d8
Compare
…ged QField project Co-authored-by: Ivan Ivanov <[email protected]>
39ba5d8
to
5118656
Compare
Hey @suricactus please have a look. |
Hey @suricactus, I added a message box that informs the user they should use the |
Hey @suricactus I added the typing hints on the new functions I added, have a look! |
… suggestion function
Hey @suricactus, I deleted the unnecessary function and joined the functions of export_folder and get_filename_suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, just realized, you never bumped libqfieldsync here. Last step before merging. I guess the tests will fail here too.
Hey @suricactus, yes, you are right. I just added the corresponding libqfieldsync dependency. |
@SeqLaz you have a conflict now. I will resolve it to unblock the tests. |
Hey @suricactus I've fixed the tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
This adds the option to specify a new project name and title in the exported project when packaging.
Related PR: opengisch/libqfieldsync#94