Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent deltas having empty strings as WKT geometry #5139

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

suricactus
Copy link
Collaborator

For some reason a geometryless layer would produce WKTs that are empty strings. Did not manage to reproduce locally, but this later fails in posgres, as ST_GeomFromText( '' ) raises.

Related PR: opengisch/QFieldCloud#917
Fix: #4796

@duke-nyuki
Copy link

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Mar 23, 2024

Copy link
Member

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we don't care about distinguishing null vs empty?

@suricactus suricactus force-pushed the QF-3987-prevent-empty-string-geom branch from 4fa2189 to cc7bc98 Compare March 23, 2024 15:17
@suricactus
Copy link
Collaborator Author

I pushed a wrong version with ignoring the empty geom. I would prefer we support empty geom.

However, is it possible to create empty geom in QField?

@nirvn
Copy link
Member

nirvn commented Mar 23, 2024

@suricactus , at the moment it is not possible to create null geometries in QGIS (and therefore QField). And it's not something that'll happen tomorrow (@m-kuhn can attest, he tried :) ).

That said, it's definitely something that might become relevant in QGIS in the future. Several formats do differentiate null vs empty.

@suricactus
Copy link
Collaborator Author

Thanks for the clarification. At least now we know QFieldCloud is empty geometry friendly as of today, I have tested POINT EMPTY and it works like a charm in the rest of the infrastructure.

@nirvn nirvn added the feedback label Mar 24, 2024
@nirvn nirvn merged commit 6a0f4d6 into master Mar 24, 2024
24 of 25 checks passed
@nirvn nirvn deleted the QF-3987-prevent-empty-string-geom branch March 24, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error pushing changes - qfieldcloud server down? #4752
4 participants